From 02f96bfcf7702107bc6a012e4bbbf84532da4fa2 Mon Sep 17 00:00:00 2001
From: ahmedk <karim.ahmed@xfel.eu>
Date: Thu, 12 Jan 2023 08:59:40 +0100
Subject: [PATCH] fix tests/test_cal_tools.py::test_raise_initialize_from_db

---
 src/cal_tools/agipdlib.py | 2 +-
 tests/test_cal_tools.py   | 4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/cal_tools/agipdlib.py b/src/cal_tools/agipdlib.py
index 0225bafa6..a22162ab4 100644
--- a/src/cal_tools/agipdlib.py
+++ b/src/cal_tools/agipdlib.py
@@ -1468,7 +1468,7 @@ class AgipdCorrections:
         missing_gain_constants = set(
             c for c in gain_constants if c not in metadata[karabo_da].keys())
         if missing_dark_constants:
-            warning(
+            raise KeyError(
                 f"Dark constants {missing_dark_constants} are not available"
                 f" for correction. Module: {karabo_da}")
         if missing_gain_constants:
diff --git a/tests/test_cal_tools.py b/tests/test_cal_tools.py
index 144e22dbd..95d08f590 100644
--- a/tests/test_cal_tools.py
+++ b/tests/test_cal_tools.py
@@ -9,7 +9,6 @@ from extra_data import open_run
 from iCalibrationDB import Conditions, ConstantMetaData, Constants
 
 from cal_tools.agipdlib import AgipdCorrections, CellRange
-from cal_tools.calcat_interface import CalCatError
 from cal_tools.plotting import show_processed_modules
 from cal_tools.tools import (
     creation_date_file_metadata,
@@ -419,8 +418,7 @@ def test_raise_initialize_from_db():
         modules=[0],
         constant_shape=(3, MEM_CELLS, 512, 128))
 
-    # CalCatError: calibration_constant_version not found !
-    with pytest.raises(CalCatError):
+    with pytest.raises(KeyError):
         agipd_corr.initialize_from_db(
             karabo_id="TEST_DET_CAL_CI-1",
             karabo_da="TEST_DET_CAL_DA1",
-- 
GitLab