From 7b3a148b3b5749b16b5611f7d32a19381012cccb Mon Sep 17 00:00:00 2001
From: ahmedk <karim.ahmed@xfel.eu>
Date: Thu, 26 Oct 2023 14:03:33 +0200
Subject: [PATCH] improve timing message based on MR suggestion and record
timing for async constant retrieval
---
.../Characterize_AGIPD_Gain_Darks_NBC.ipynb | 22 +++++++++++++------
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/notebooks/AGIPD/Characterize_AGIPD_Gain_Darks_NBC.ipynb b/notebooks/AGIPD/Characterize_AGIPD_Gain_Darks_NBC.ipynb
index 913498240..cc60547a5 100644
--- a/notebooks/AGIPD/Characterize_AGIPD_Gain_Darks_NBC.ipynb
+++ b/notebooks/AGIPD/Characterize_AGIPD_Gain_Darks_NBC.ipynb
@@ -236,8 +236,8 @@
"# Update modules and karabo_da lists based on available modules to processes.\n",
"modules = [m for m in modules if m not in missing_modules]\n",
"karabo_da = create_karabo_da_list(modules)\n",
- "\n",
- "step_timer.done_step(f\"Will process data of ({sum(mod_image_size):.02f} GB).\")"
+ "print(f\"Will process data of ({sum(mod_image_size):.02f} GB).\")\n",
+ "step_timer.done_step(\"Checking the data size and availability.\")"
]
},
{
@@ -692,6 +692,11 @@
"\n",
"\n",
"def retrieve_old_constant(qm, const):\n",
+ "\n",
+ " import time\n",
+ "\n",
+ " st = time.time()\n",
+ "\n",
" dconst = getattr(iCalibrationDB.Constants.AGIPD, const)()\n",
"\n",
" data, mdata = get_from_db(\n",
@@ -718,15 +723,15 @@
" mdata.calibration_constant_version.filename\n",
" )\n",
" h5path = mdata.calibration_constant_version.h5path\n",
- "\n",
- " return data, timestamp, filepath, h5path\n",
+ " \n",
+ " return data, timestamp, filepath, h5path, time.time() - st\n",
"\n",
"\n",
"old_retrieval_pool = multiprocessing.Pool()\n",
"old_retrieval_res = old_retrieval_pool.starmap_async(\n",
" retrieve_old_constant, qm_x_const\n",
")\n",
- "old_retrieval_pool.close()"
+ "old_retrieval_pool.close()\n"
]
},
{
@@ -934,13 +939,16 @@
"old_mdata = {}\n",
"old_retrieval_res.wait()\n",
"\n",
- "for (qm, const), (data, timestamp, filepath, h5path) in zip(qm_x_const, old_retrieval_res.get()):\n",
+ "timings = []\n",
+ "for (qm, const), (data, timestamp, filepath, h5path, timing) in zip(qm_x_const, old_retrieval_res.get()):\n",
" old_const.setdefault(qm, {})[const] = data\n",
" old_mdata.setdefault(qm, {})[const] = {\n",
" \"timestamp\": timestamp,\n",
" \"filepath\": filepath,\n",
" \"h5path\": h5path\n",
- " }"
+ " }\n",
+ " timings.append(timing)\n",
+ "print(f\"Retrieving old constant took around {np.asarray(timings).mean():.01f} s\")"
]
},
{
--
GitLab