From 8bfbd104bed6931de793b54f2a36624adaa6e7a8 Mon Sep 17 00:00:00 2001
From: ahmedk <karim.ahmed@xfel.eu>
Date: Thu, 13 Oct 2022 15:14:04 +0200
Subject: [PATCH] [JUNGFRAU][DARK] Fixing BadPixelsDark WRONG_GAIN_VALUE
---
.../Jungfrau_dark_analysis_all_gains_burst_mode_NBC.ipynb | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/notebooks/Jungfrau/Jungfrau_dark_analysis_all_gains_burst_mode_NBC.ipynb b/notebooks/Jungfrau/Jungfrau_dark_analysis_all_gains_burst_mode_NBC.ipynb
index f86b43649..15c23af34 100644
--- a/notebooks/Jungfrau/Jungfrau_dark_analysis_all_gains_burst_mode_NBC.ipynb
+++ b/notebooks/Jungfrau/Jungfrau_dark_analysis_all_gains_burst_mode_NBC.ipynb
@@ -304,9 +304,10 @@
" noise_map[mod][..., cell_number, gain] = np.std(thiscell, axis=2)\n",
"\n",
" # Check if there are wrong bad gain values.\n",
- " # Indicate pixels with wrong gain value across all trains for each cell.\n",
- " bad_pixels_map[mod][\n",
- " np.average(gain_vals[..., cell_slice_idx], axis=2) != raw_g] |= BadPixels.WRONG_GAIN_VALUE.value\n",
+ " # Indicate pixels with wrong gain value for any train for each cell.\n",
+ " gain_avg = np.average(gain_vals[..., cell_slice_idx], axis=2)\n",
+ " # TODO: Set a threshold for acceptable gain average values across trains.\n",
+ " bad_pixels_map[mod][..., cell_number, gain][gain_avg != raw_g] |= BadPixels.WRONG_GAIN_VALUE.value\n",
" print(f\"Gain stage {gain}, run {run_n}\")\n",
"\n",
" # load shape of data for memory cells, and detector size (imgs, cells, x, y)\n",
--
GitLab