From b91aa28837e0a85d527dd4336ff40d416b3b6fa8 Mon Sep 17 00:00:00 2001
From: ahmedk <karim.ahmed@xfel.eu>
Date: Wed, 19 Jul 2023 13:32:54 +0200
Subject: [PATCH] fix including thresholds in error missing constants
---
notebooks/AGIPD/AGIPD_Correct_and_Verify.ipynb | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/notebooks/AGIPD/AGIPD_Correct_and_Verify.ipynb b/notebooks/AGIPD/AGIPD_Correct_and_Verify.ipynb
index 15581138c..3b2a993be 100644
--- a/notebooks/AGIPD/AGIPD_Correct_and_Verify.ipynb
+++ b/notebooks/AGIPD/AGIPD_Correct_and_Verify.ipynb
@@ -626,10 +626,11 @@
" mod = modules[karabo_da.index(da)]\n",
" # Constants to error out for when missing.\n",
" error_missing_constants = {\"Offset\"}\n",
- " if gain_mode:\n",
+ " if not gain_mode:\n",
" error_missing_constants |= {\"ThresholdsDark\"}\n",
"\n",
- " if error_missing_constants - set(calibrations):\n",
+ " error_missing_constants -= set(calibrations)\n",
+ " if error_missing_constants:\n",
" warning(f\"Offset constant is not available to correct {da}.\")\n",
" # Remove module from files to process.\n",
" del mapped_files[module_index_to_qm(mod)]\n",
@@ -638,7 +639,7 @@
"\n",
" warn_missing_constants = set(dark_constants + gain_constants)\n",
" warn_missing_constants -= error_missing_constants\n",
- " warn_missing_constants = warn_missing_constants - set(calibrations)\n",
+ " warn_missing_constants -= set(calibrations)\n",
" if warn_missing_constants:\n",
" warning(f\"Constants {warn_missing_constants} were not retrieved for {da}.\")\n",
"\n",
--
GitLab