From fcc436b8e54cf8298b35ac5e575244e0264511a8 Mon Sep 17 00:00:00 2001
From: David Hammer <dhammer@mailbox.org>
Date: Fri, 23 Apr 2021 17:49:49 +0200
Subject: [PATCH] Computing thresholding bad pixels for each qm

---
 .../AGIPD/Characterize_AGIPD_Gain_Darks_NBC.ipynb | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/notebooks/AGIPD/Characterize_AGIPD_Gain_Darks_NBC.ipynb b/notebooks/AGIPD/Characterize_AGIPD_Gain_Darks_NBC.ipynb
index 9201b66fd..3397ba745 100644
--- a/notebooks/AGIPD/Characterize_AGIPD_Gain_Darks_NBC.ipynb
+++ b/notebooks/AGIPD/Characterize_AGIPD_Gain_Darks_NBC.ipynb
@@ -504,13 +504,16 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "# Add a badpixel due to bad gain separation\n",
+    "# Add bad pixels due to bad gain separation\n",
     "if not fixed_gain_mode:\n",
-    "    for g in range(2):\n",
-    "        # Bad pixels during bad gain separation.\n",
-    "        # Fraction of pixels in the module with separation lower than \"thresholds_gain_sigma\".\n",
-    "        bad_sep = (gain_g[qm][..., g+1] - gain_g[qm][..., g]) / np.sqrt(gainstd_g[qm][..., g+1]**2 + gainstd_g[qm][..., g]**2)\n",
-    "        badpix_g[qm][...,g+1][(bad_sep)<thresholds_gain_sigma]|= BadPixels.GAIN_THRESHOLDING_ERROR"
+    "    for qm in gain_g.keys():\n",
+    "        for g in range(2):\n",
+    "            # Bad pixels during bad gain separation.\n",
+    "            # Fraction of pixels in the module with separation lower than \"thresholds_gain_sigma\".\n",
+    "            bad_sep = (gain_g[qm][..., g+1] - gain_g[qm][..., g]) / \\\n",
+    "                np.sqrt(gainstd_g[qm][..., g+1]**2 + gainstd_g[qm][..., g]**2)\n",
+    "            badpix_g[qm][...,g+1][bad_sep<thresholds_gain_sigma] |= \\\n",
+    "                BadPixels.GAIN_THRESHOLDING_ERROR"
    ]
   },
   {
-- 
GitLab