Suggested Improvements
-
use acronyms in the description of detector parameters to be set -
minor?: use numerical KRB properties for numbers instead of string (e.g., GAIN) -
For MinValue et al. in description we could state the interval they refer to. Also, this interval, now hard-coded in the code as 1 second, could be put in the header as constant. -
Verify the issue of enabling the pulse generation; its parameters are changed at the moment only when the enabling is set. -
does it make sense to handle error returns from handle_reply calls? -
minor: could have a dedicated function to reset the list-related variables?
Edited by Andrea Parenti