Skip to content
Snippets Groups Projects

Add Mnemonics for HRIXS

Merged Add Mnemonics for HRIXS
mnemo into master
Merged Martin Teichmann requested to merge mnemo into master

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
src/toolbox_scs/constants.py
325 331 'key': 'result.value',
326 332 'dim': None},),
327 333
334 "Delay": ({'source': 'SCS_ILH_LAS/MDL/OPTICALDELAY_LT3',
  • Laurent Mercadier
    Laurent Mercadier @mercadil ·
    Maintainer

    "Delay" is in my opinion too general. How about "PP800_Delay_ps"?

    I am also concerned about using the delay calculated by this MDL. It is error prone because T0 is set manually and arbitrarily, sign can be inverted...

  • Martin Teichmann
    Martin Teichmann @teichman ·
    Author Owner

    I actually agree, and it is actually not such an important parameter, as the delay is also available as hRIXS_delay, which is much more useful. So I take this one out.

  • Please register or sign in to reply
  • Martin Teichmann added 1 commit

    added 1 commit

    Compare with previous version

  • Martin Teichmann merged

    merged

  • Martin Teichmann mentioned in commit 4d1c1626

    mentioned in commit 4d1c1626

    • Please register or sign in to reply

    Legal Notice | Contacts