No pulse pattern info case

2019-04-30_XAS_field_with_pulse_selection_p2170_Ni_scan.html.pdf

See attached notebook. It gives an ValueError on December 2018 data. Am I using it wrong ?

Since we don't have the bunch pattern, we cannot infer how many pulses are in sase1 and sase3. You need to specify the number of pulses (kwarg npulses=...) you want to retrieve and which sase comes first (kwarg sase3First=...)

I see, but matchXgmTimPulseId doesn't have these keywords. Shouldn't we pass them there ?

Yes! I just commited the changes

added 1 commit

• 0ae0897c - Adds arguments in matchXgmTimPulseId() for no bunch pattern info case

Compare with previous version

added 1 commit

• aa19e723 - raise TypeError if npulses missing when no pulse pattern info is available

Compare with previous version

Tested, looks good. The raised exception message is a good idea.

merged

mentioned in commit 5ef09113