Add __init__.py files to some subpackages
Merge request reports
Activity
in principle fine for me. But since I am the one developing this branch, may I also be informed what this is about? I am asking because the development is still ongoing. I am of course happy if others participate, but it would be nice to know, not that we are working on the same things in parallel.
The
__init__.pyfiles mark that a directory is a package (subpackage, in this case). Even if they're empty, they're relevant for the way Python imports work.I don't think we're planning to do anything else with this at the moment, so we shouldn't be duplicating any of your effort. We were just asked to help with a notebook using your branch, and found that we needed to make this change before it would run.
Hi Thomas The meaning of the init file is clear, I don't have objections here. I will do the merge.
But nevertheless, I think there is some miscommunication here. The only notebooks using my branch were created by me so far. I only started introducing coworkers about a week ago and its still work in progress. Therefore, I am pretty sure that whoever asked for your help is using a notebook that is actually based on code in the master branch. Is this about the knife edge scans and was triggered by Ben? If so; I already looked at these measurements. They need to be redone, since the sample stage was not recorded properly.
mentioned in commit cf176015
-
The instruction to use your branch was from Nanna Zhou Hagstrom, an external user who has a beamtime starting next week. It's certainly possible that she has misunderstood - maybe she was looking for a branch with an installable package, for instance. We followed the steps she sent so we were working with the same code as her, but the SCS toolbox wasn't really central to that.
If you want all the details of how we got here, you should be able to see our Redmine ticket at https://in.xfel.eu/redmine/issues/71134
