Skip to content

fix(calibration_trends): slice ccvs correctly and some other small fixes

Karim Ahmed requested to merge fix/calibration_trends_correct_data_to_timestamps into master

Description

This MR addresses and fixes the issue of incorrect data being associated with the wrong timestamps during the loading of calibration data. Problem

Previously, the code had a bug that resulted in the incorrect number of calibration constants (CCVs) being attached for timestamps for each module. This issue led to confusing plots where, if one module missed some CCVs for certain timestamps, it would appear that all other modules lacked data for other timestamps. This caused false interpretations of the data's availability and trends.

This fix improves the accuracy and reliability of the calibration trends plots, ensuring that users can trust the visualized data to reflect the true availability and trends of calibration constants across all modules.

Changes Made

  • Simplified Futures Creation: Replaced the complex dictionary comprehension for creating futures with a straightforward loop.
  • Correct Data Association: Ensured that data is correctly appended to the time_data dictionary, matching timestamps with their respective values to prevent mismatches.

Screenshots

Example of misleading plot due to incorrect timestamp data association

Screenshot_from_2024-05-27_18-06-10

Screenshot_from_2024-05-27_19-21-37

Example of correct plot with accurate timestamp data association

Screenshot_from_2024-05-27_18-06-03

Screenshot_from_2024-05-27_19-21-44

Related Issues

Tests

Additional Notes

Merge Request Checklist

  • Code follows project coding guidelines.
  • Documentation reflects the changes made.
  • Unit tests are added or updated to cover the changes.
  • The application runs without errors and the new functionality works as expected.
Edited by Karim Ahmed

Merge request reports

Legal Notice | Contacts