Skip to content

Fix and Feat: Calibration Trends and Compare Maps

Karim Ahmed requested to merge fix/move_to_data_frames_fix_unsorted_ccvs into master

Description

While preparing calibration I realized a bug when plotting AGIPD module CCVs in calibration trends and compare maps pages.

As shown below in the first image. It seems that one module is missing a CCV on 8th of July. This is incorrect. The CCVs were not sorted properly and both modules have CCVs injection with a timestamp different in seconds.

I decided to plot the CCVs in days/months/hours/minutes only. In that way, these kinds of CCVs are going to be collected on the same points.

The correct plot is shown in the second image along with the added table to show the number of retrieved CCVs

Changes Made

  • Flake 8 for all updated files for tests
  • Fix(calibration_trends): sort CCVs by timestamp and show CCVs until minutes only. (e.g.) CCVs could have slight difference in timestamp in seconds.
  • Open up number of retrieved CCVs per module to 500 instead of 20
  • Change compare maps num_constants key widget to separate from other pages.
  • Update utils functions (tests will need to be updated later)
  • Use dataframes in calibration trends instead of dictionaries for clearer code.

Screenshots

Wrong plot(bug) MR plot(bugfix) New_num_constants_max

Related Issues

Tests

Additional Notes

Merge Request Checklist

  • Code follows project coding guidelines.
  • Documentation reflects the changes made.
  • Unit tests are added or updated to cover the changes.
  • The application runs without errors and the new functionality works as expected.
Edited by Karim Ahmed

Merge request reports