Skip to content

Draft: small JF tweaks from HED installation

David Hammer requested to merge hed-jungfrau-tweaks into master

Note: I realized that some missing bits would work out better after the refactoring of https://git.xfel.eu/karaboDevices/calng/-/merge_requests/26, so I rebased on that. To make diff reasonable, am pointing this MR against that branch - hoping to merge the other MR first, then point this MR to master before merging.

Currently in:

  • set default to not flip preview output for standalone mode (hotpatched for hedonc@exflong11)

Planned:

  • option to mask "double size pixel" strixel pixels
    • masking would work the same as masking normal double size pixels
    • note: strixel is treated as correction step, so can be independently toggled for full / preview outputs; the bad pixel map is the same in each case, so one output would have the wrong double size pixels masked (I'm thinking to let full output take precedence until a smarter solution is found)
  • option to take average in the case of double size strixels
    • trying to correct rather than mask double size pixels is a thing some people think about
    • in this setting, we could have the flexibility and compute headroom to just explicitly divide all BadPixelValues.NON_STANDARD_SIZE pixels by two
Edited by David Hammer

Merge request reports

Loading