Skip to content

Remove unnecessary 'module load' command from jobs to be repeated

Thomas Kluyver requested to merge repeat-rm-anaconda3 into master

Description

The notebook runner script was unnecessarily loading the old anaconda/3 module (fixed in !1006 (merged)). This script is copied into each work directory, and used by xfel-calibrate-repeat, so we can change the script for new jobs without affecting reproducibility. However, that does mean we need a workaround to run these scripts on EL9, which won't have the old module.

This implements what seems to be the simplest workaround - edit that line out of the script.

How Has This Been Tested?

Running:

xfel-calibrate-repeat /gpfs/exfel/exp/CALLAB/202031/p900113/usr/Reports/r9980/slurm_out_JUNGFRAU_CORRECT_t221104_124413.692549 \
  --out-folder /gpfs/exfel/data/scratch/kluyvert/repeat-callab-r9980-rm-anaconda3

And checking that the script in the copied work directory has the relevant line removed. The snippet around where it was:

export CAL_NOTEBOOK_NAME="$notebook"

# set-up enviroment
source /etc/profile.d/modules.sh

# make sure we use agg backend
export MPLBACKEND=AGG

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.

Reviewers

@schmidtp @ahmedk

Merge request reports