Skip to content
Snippets Groups Projects

fix(GH2): skip plots if no raw data corrected in a notebook

Merged Karim Ahmed requested to merge fix/exit_notebook_when_no_correct_gh2 into master
All threads resolved!

Description

This MR addresses this issue for erroring out for one sequence file with no trains to correct.

How Has This Been Tested?

Relevant Documents (optional)

issue_r60_test_gh2.pdf

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@schmidtp @kluyvert

Edited by Karim Ahmed

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Karim Ahmed added 1 commit

    added 1 commit

    • f67bcda4 - refactor: improve messages and add exit_notebook to epix100

    Compare with previous version

  • Karim Ahmed added 1 commit

    added 1 commit

    • d2676802 - fix: simpler and clearer message

    Compare with previous version

  • Karim Ahmed resolved all threads

    resolved all threads

  • Thanks for the review!

  • merged

  • Karim Ahmed mentioned in commit c4953558

    mentioned in commit c4953558

  • Philipp Schmidt changed milestone to %3.15.1

    changed milestone to %3.15.1

  • Please register or sign in to reply
    Loading