Skip to content

HOTFIXED [AGIPD][Correct]: Fix assumption that all modules follow quadrant convetion under 16 modules

Karim Ahmed requested to merge fix/wrong_assumptions_AGIPD_HiZ into master

Description

While Testing AGIPD HiZ, the correction failed because of the assumption we have of 16 modules and using the QM naming convention

http://max-exfl-cal001.desy.de:8008//gpfs/exfel/exp/HED/202431/p900478/usr/Reports/r0044/HED_TST_AGIPDHZ1_correct_900478_r0044_241107_104257_447047.pdf

For the sake of fast Hotfix I did this MR. However I want to sill go into this direction and even better reconsider the importance of QM convention. Otherwise we shrink its usage for the AGIPD1M detectors and maybe later with the AGIPD4M

THIS IS HOTFIXED!

How Has This Been Tested?

Tested the failed mentioned run and I will run now the CI for the rest of AGIPD detectors

Relevant Documents (optional)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@jsztuk @schmidtp @kluyvert

Merge request reports