Fix: Do not apply mg shift by default (!168) · Merge requests · calibration / pycalibration · GitLab

Snippets Groups Projects

Merged Mikhail Karnevskiy requested to merge fix/no_mg_shift into master 5 years ago

1 unresolved thread

@ahmedk Medium gain shift of the offset should not be applied by default.

Activity

Karim Ahmed @ahmedk started a thread on the diff 5 years ago

cal_tools/cal_tools/agipdlib.py

                     med = np.nanmedian(ado, axis=(1, 2))[:, None, None]
                     doff[:, i * 64:(i + 1) * 64, j * 64:(j + 1) * 64] = med
             self.offset[..., 1] += doff
             # self.offset[..., 1] += doff

Karim Ahmed @ahmedk · 5 years ago

Owner

beside the tiny comment, LGTM

Mikhail Karnevskiy added 1 commit 5 years ago

added 1 commit

1afea91f - Do not apply mg shift by default

Compare with previous version

Mikhail Karnevskiy merged 5 years ago

merged

Mikhail Karnevskiy mentioned in commit 5 years ago

mentioned in commit 8352b28b

Please register or sign in to reply

Legal Notice | Contacts