Skip to content
Snippets Groups Projects

FIX/Include run number in out -folder path if missing

Merged Karim Ahmed requested to merge fix/xfel_calibrate_update_bugs into master
All threads resolved!

@karnem with your last additions for removing the run from the folder as it is always written in the webservice. The pdfs are stored outside of the folder if calibration is ran through the command line

Edited by Karim Ahmed

Merge request reports

Approval is optional

Merged by Karim AhmedKarim Ahmed 5 years ago (Jan 8, 2020 8:54am UTC)

Merge details

  • Changes merged into master with 2b52810e.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Karim Ahmed changed title from write run name in folder when not prod to FIX/Include run number in out -folder path if missing

    changed title from write run name in folder when not prod to FIX/Include run number in out -folder path if missing

  • Karim Ahmed added 1 commit

    added 1 commit

    Compare with previous version

  • Karim Ahmed
  • please review this @karnem.

    if review is done later while I am not available and there are no more needed changes please merge.

  • Karim Ahmed added 2 commits

    added 2 commits

    • 0fd85705 - change args out-folder with out-path
    • 3c65cf5e - solve merge conflicts

    Compare with previous version

  • Karim Ahmed added 1 commit

    added 1 commit

    Compare with previous version

  • Karim Ahmed resolved all discussions

    resolved all discussions

  • merged

  • Karim Ahmed mentioned in commit 2b52810e

    mentioned in commit 2b52810e

  • Please register or sign in to reply
    Loading