Fix: Enable variation of ports in DB interface (!247) · Merge requests · calibration / pycalibration · GitLab

Snippets Groups Projects

Merged Mikhail Karnevskiy requested to merge fix/db_interface into master 5 years ago

1 unresolved thread

Activity

Mikhail Karnevskiy @karnem started a thread on the diff 5 years ago

notebooks/pnCCD/Correct_pnCCD_NBC.ipynb

706	706	" print(\"Couldn't calibrate data in {}: {}\".format(f, e))\n"
707	707	]
708	708	},
709		{
Mikhail Karnevskiy @karnem · 5 years ago Author Contributor Without this plot it runs much faster. Karim Ahmed @ahmedk · 5 years ago Owner @setoodeh we are going to remove this plot from the pnccd notebook as it is faster (~5mins) without it and we think the already shown plots in the report should be enough. Is this ok for you? Kiana Setoodehnia @setoodeh · 5 years ago Contributor Hi Karim, I suppose that is fine. Thanks Please register or sign in to reply

Mikhail Karnevskiy added 1 commit 5 years ago

added 1 commit

9b0d46fd - Enable variation of ports in DB interface

Compare with previous version

Mikhail Karnevskiy added 1 commit 5 years ago

added 1 commit

f620e2e0 - Enable variation of ports in DB interface

Compare with previous version

Karim Ahmed @ahmedk · 5 years ago

Owner

other than my question to @setoodeh, LGTM

Mikhail Karnevskiy @karnem · 5 years ago

Author Contributor

I will merge, create a new tag and test it again.

Mikhail Karnevskiy merged 5 years ago

merged

Mikhail Karnevskiy mentioned in commit 5 years ago

mentioned in commit 0fa4bbf8

Please register or sign in to reply

Legal Notice | Contacts