wrong argument order in save_const_to_h5
2 unresolved threads
2 unresolved threads
@danilevc This is a fix for a last minute change in the last PR which was already reviewed and merged
Merge request reports
Activity
Filter activity
For the record, I guess that previous PR you mentioned is !348 (merged).
Looking at the diff from !348 (merged), this change LGTM.
I think it's generally be a good idea to use keyword arguments when calling functions with this many parameters, so that the order doesn't matter.
mentioned in commit 3fa2cd9e
Please register or sign in to reply