convert facecolors to nparray (!390) · Merge requests · calibration / pycalibration · GitLab

Snippets Groups Projects

Merged Karim Ahmed requested to merge fix/facecolor_array_extra_geom into master 4 years ago

Summary:

This is a fix for a bug while trying to create extra_geom assembled plot

Report:

AGIPDCharacterizeDarkImages.pdf

Reviewers:

@danilevc @kamile

Edited 4 years ago by Karim Ahmed

Activity

Karim Ahmed changed the description 4 years ago

changed the description
Cyril Danilevski @danilevc · 4 years ago

Owner

It looks like some rebasing went awry, it should be np.repeat as done here
Cyril Danilevski @danilevc · 4 years ago

Owner

Had we had a CI, we would have caught that, but I'm told it's not a priority
Karim Ahmed added 1 commit 4 years ago
added 1 commit

6cbe189f - np.repeat instead of np.array

Compare with previous version
Cyril Danilevski @danilevc · 4 years ago

Owner

Thanks for the fix! LGTM
Karim Ahmed merged 4 years ago

merged
Karim Ahmed mentioned in commit 7788fc8f 4 years ago

mentioned in commit 7788fc8f

Please register or sign in to reply

Legal Notice | Contacts