Skip to content
Snippets Groups Projects

Extend slopesFF with last usable cell

Merged Karim Ahmed requested to merge fix/expand_FF_with_last_useable_cell into master
All threads resolved!

Summary:

This is a fix for applying xray-cor. Before We were extending the SlopesFF constant with ones if it is a development SlopesFF with not all of (128, 512, < mem_cells) expected cells. But old constant is already of shape (128, 512, 2).

This MR introduces:

  1. different expansion. AS it is better to use last usable memory cells for SlopesFF.

  2. ff_gain, a conversion gain parameter that is used in case of absolute SlopesFF gain constant. Which is the case for the new FFs

Testing:

Retrieving SlopesFF from DB

xfel-calibrate AGIPD CORRECT \
--slurm-mem 750 \
--slurm-name cor_SPB_98 \
--karabo-da -1 \
--receiver-id {}CH0 \
--karabo-id-control SPB_IRU_AGIPD1M1 \
--karabo-da-control AGIPD1MCTRL00 \
--h5path-ctrl /CONTROL/{}/MDL/FPGA_COMP_TEST \
--overwrite --sequences-per-node 1 \
--in-folder /gpfs/exfel/exp/SPB/202030/p900119/raw/ \
--out-folder /gpfs/exfel/data/scratch/ahmedk/test/SPB_AGIPD2 \
--karabo-id SPB_DET_AGIPD1M-1 \
--run 98 --blc-stripes \
--rel-gain \
--adjust-mg-baseline \
--blc-set-min \
--xray-gain \
--force-hg-if-below \
--force-mg-if-below \
--low-medium-gap \
--zero-nans \
--zero-orange \
--sequences 0 \

Retrieving SlopesFF given local path

xfel-calibrate AGIPD CORRECT \
--slurm-mem 750 \
--slurm-name correct_MID_agipd_319 \
--karabo-id MID_DET_AGIPD1M-1 \
--karabo-id-control MID_EXP_AGIPD1M1 \
--karabo-da-control AGIPD1MCTRL00 \
--h5path-ctrl /CONTROL/{}/MDL/FPGA_COMP \
--overwrite \
--in-folder /gpfs/exfel/exp/MID/202030/p900137/raw/ \
--out-folder /gpfs/exfel/data/scratch/ahmedk/test/AGIPD_FF \
--slopes-ff-from-files /gpfs/exfel/d/proc/MID/202031/p900148/proc_vtst/cascella//FF/GAIN_MAPS/202cells2.2MHz.4p.lim1.gs0r319r322r324/ \
--run 319 \
--sequences 74 \
--modules 4 \

Reviewers:

@danilevc @kamile @jsztuk

Edited by Karim Ahmed

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Karim Ahmed unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Karim Ahmed changed title from WIP: extend slopesFF with last useable cell to Extend slopesFF with last usable cell

    changed title from WIP: extend slopesFF with last useable cell to Extend slopesFF with last usable cell

  • Karim Ahmed changed the description

    changed the description

  • Karim Ahmed
  • Karim Ahmed resolved all discussions

    resolved all discussions

  • Karim Ahmed added 1 commit

    added 1 commit

    • 5ab68fed - Apply suggestion to cal_tools/cal_tools/agipdlib.py

    Compare with previous version

  • Karim Ahmed added 1 commit

    added 1 commit

    • c6307f41 - Apply suggestion to cal_tools/cal_tools/agipdlib.py

    Compare with previous version

  • Ebad Kamil
  • Ebad Kamil
  • Ebad Kamil
  • LGTUs

  • Ebad Kamil added 1 commit

    added 1 commit

    • 2772e1f8 - Apply suggestion to cal_tools/cal_tools/agipdlib.py

    Compare with previous version

  • Ebad Kamil added 1 commit

    added 1 commit

    • cde4292e - Apply suggestion to cal_tools/cal_tools/agipdlib.py

    Compare with previous version

  • Ebad Kamil resolved all discussions

    resolved all discussions

  • Ebad Kamil added 1 commit

    added 1 commit

    • f7db3982 - Apply suggestion to cal_tools/cal_tools/agipdlib.py

    Compare with previous version

  • merged

  • Ebad Kamil mentioned in commit bf5e2985

    mentioned in commit bf5e2985

  • Please register or sign in to reply
    Loading