Skip to content
Snippets Groups Projects

Fix/3.0.0-test04 on max-exfl017: proposal-yaml, AGIPD correct, PnCCD notebooks, and DSSC dark

Merged Karim Ahmed requested to merge fix/3.0.0-test04 into master
All threads resolved!

Summary:

These are some fixes:

1- for the ending for proposal YAML configuration files 2- adding back non-pushed fixes and modifications for PNCCD notebooks related to this MR: https://git.xfel.eu/gitlab/detectors/pycalibration/merge_requests/371 3- Fixing wrong use of and for agipdlib pulses selection

Reviewers:

@hammerd @danilevc

Edited by Karim Ahmed

Merge request reports

Checking pipeline status.

Merged by Karim AhmedKarim Ahmed 4 years ago (Feb 10, 2021 5:22pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • David Hammer
  • David Hammer resolved all discussions

    resolved all discussions

  • Karim Ahmed
  • Karim Ahmed resolved all discussions

    resolved all discussions

  • Karim Ahmed added 1 commit

    added 1 commit

    • 5f1d664a - Apply suggestion to notebooks/DSSC/Characterize_DSSC_Darks_NBC.ipynb

    Compare with previous version

  • Thanks for the review!

  • merged

  • Karim Ahmed mentioned in commit c332e608

    mentioned in commit c332e608

  • Please register or sign in to reply
    Loading