Skip to content
Snippets Groups Projects

Fix/DSSC DARK was missing from the new mapping modifications

Merged Karim Ahmed requested to merge fix/DSSC_DARK_new_mapping into master
All threads resolved!

Summary:

As we had old DSSC test data we missed this during our tests. Yesterday after adding new test data for DSSC. I tested dark and found this silly mistake that DSSC was missing from the new mapping additions.

Tests:

This was tested locally on the notebook and was hotpatched to max-exfl016 in the meantime to not block today's tests.

Report from production: http://max-exfl016:8008//gpfs/exfel/d/cal/caldb_store/xfel/reports/CALLAB/SCS_DET_DSSC1M-1/dark/dark_900113_r9982_210212_092238.pdf

Reviewers:

@danilevc @hammerd

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Karim Ahmed resolved all discussions

    resolved all discussions

  • Karim Ahmed added 1 commit

    added 1 commit

    • 8714dd79 - Apply suggestion to notebooks/DSSC/Characterize_DSSC_Darks_NBC.ipynb

    Compare with previous version

  • Thank you for the review!

  • Karim Ahmed added 1 commit

    added 1 commit

    Compare with previous version

  • merged

  • Karim Ahmed mentioned in commit 04469bf5

    mentioned in commit 04469bf5

  • Please register or sign in to reply
    Loading