Skip to content

Fix/update config

Karim Ahmed requested to merge fix/update_config into master

Description

This MR is related to the issue: https://git.xfel.eu/gitlab/calibration/planning/issues/7

This fixes bugs for: 1- Negative booleans -no{} was not properly appended to available configurations. 2- Updating the config for SPB_DET_AGIPD1M-1 and creating a new proposal.yml could cause errors for proposals with multiple detectors of an instrument. As the rest of the detectors instrument configs were not copied along. 3- Add some refactors for code clarity and using Pathlib.

How Has This Been Tested?

This was tested on max-exfl015:5555

python update_config.py \
--karabo-id SPB_DET_AGIPD1M-1 \
--proposal 000000 --cycle 000000 \
 --no-rel-gain true \
--webservice-address tcp://max-exfl015:5555 \
--apply

Relevant Documents (optional)

Commit before the fix:

Commit after the fix:

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Docs (changes to the documentation)
  • Refactor (refactoring code with no functionality changes)

Checklist:

  • My code follows the code style of this project.

Reviewers

@calibration @kluyvert

Edited by Karim Ahmed

Merge request reports