Skip to content

[AGIPD][CORRECT] Correctly set array of ones when no PC data available

Cyril Danilevski requested to merge fix/md_offset_bug into master

Description

This fixes issue https://git.xfel.eu/gitlab/detectors/calibration_workshop/issues/260 , which describes how a bug was introduced following refactoring.

We used set a default value for rel_gain in the same else context, but this was changed, and now rel_gain has a different shape altogether.

In this MR, the array is initialized correctly, and no longer copied from rel_gain.

How Has This Been Tested?

This was tested by Jola on a known problematic dataset.

Relevant Documents (optional)

The report is at: /gpfs/exfel/exp/MID/202031/p900148/proc/proc_vtst/test_jola/p002929/r0023/temp/slurm_out_AGIPD_CORRECT_t210413_173612/sphinx_rep/_build/latex/agipdofflinecorrection.pdf

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Reviewers

@calibration

Merge request reports