Skip to content

[AGIPD][JF]Fix: Use all available sequences for processing darks

Karim Ahmed requested to merge fix/use_all_sequences_for_darks into master
  • Fix: for AGIPD to use all sequences for dark processing.
  • Refactor: removing sequence parameter for JF, which is not used.

Description

This is related to https://git.xfel.eu/gitlab/calibration/planning/issues/72

How Has This Been Tested?

Through running xfel-calibrate for producing the following reports.

AGIPD:

xfel-calibrate AGIPD DARK \
--in-folder /gpfs/exfel/exp/SPB/202130/p900201/raw \
--run-high 343 --run-med 344 --run-low 345 \
--out-folder /gpfs/exfel/data/scratch/ahmedk/test/AGIPD \
--karabo-id-control SPB_IRU_AGIPD1M1 \
--karabo-da-control AGIPD1MCTRL00 \
--karabo-id SPB_DET_AGIPD1M-1

JF:

xfel-calibrate JUNGFRAU DARK \
--in-folder /gpfs/exfel/exp/SPB/202130/p900204/raw/ \
--run-high 141 --run-med 142 --run-low 143 \
--out-folder /gpfs/exfel/data/scratch/ahmedk/test/JF

Relevant Documents (optional)

AGIPD: AGIPDCharacterizeDarkImages.pdf JF: JungfrauDarkImageCharacterization.pdf

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (refactoring code with no functionality changes)

Checklist:

  • My code follows the code style of this project.

Reviewers

@kluyvert @danilevc

Edited by Karim Ahmed

Merge request reports