Fix the old time-summary (creation time for retrieved constants)
The time summary was broken. The information was there elsewhere, so the issue was just in compiling the summary. Reported by Johannes: https://in.xfel.eu/redmine/issues/99561
Overview
I probably broke this at some point and https://in.xfel.eu/redmine/issues/99561 Johannes noticed.
It's technically redundant information in the metadata YAML, but this also means that it should be an easy fix.
Seems it was just missing the [...]["constants"][...]
in looking stuff up in a dict.
How this has been tested
I will do a test to check that it makes it into the report correctly.
Running a "full" job seems fine.
Here's a report:
report.pdf
And the command was just re-running using slightly modified run-calibrate.sh from the job Johannes mentioned:
TESTDIR="/gpfs/exfel/data/scratch/hammerd/test/misc-pycalibration"
xfel-calibrate agipd CORRECT \
--slurm-scheduling 80 \
--slurm-mem 750 \
--request-time 2021-06-21T10:17:55 \
--slurm-name correct_MID_agipd_202002_p002616_r143 \
--report-to "${TESTDIR}/report" \
--cal-db-timeout 300000 \
--cal-db-interface tcp://max-exfl016:8015#8044 \
--karabo-da AGIPD00 AGIPD01 AGIPD02 AGIPD03 AGIPD04 AGIPD05 AGIPD06 AGIPD07 AGIPD08 AGIPD09 AGIPD10 AGIPD11 AGIPD12 AGIPD13 AGIPD14 AGIPD15 \
--receiver-id {}CH0 \
--karabo-id-control MID_EXP_AGIPD1M1 \
--karabo-da-control AGIPD1MCTRL00 \
--h5path-ctrl /CONTROL/{}/MDL/FPGA_COMP \
--overwrite \
--sequences-per-node 1 \
--bias-voltage 300 \
--force-hg-if-below \
--hg-hard-threshold 1000 \
--force-mg-if-below \
--mg-hard-threshold 1000 \
--blc-stripes \
--common-mode \
--cm-dark-range -30 30 \
--cm-dark-fraction 0.15 \
--cm-n-itr 4 \
--rel-gain \
--adjust-mg-baseline \
--blc-set-min \
--low-medium-gap \
--ff-gain 7.2 \
--in-folder /gpfs/exfel/exp/MID/202002/p002616/raw \
--out-folder "${TESTDIR}/data" \
--karabo-id MID_DET_AGIPD1M-1 \
--run 143 \
--priority 2
Reviewers
Is this enough to bother with a hotfix? Clearly the lack of summary is annoying to users. OTOH, the information is available in the report outside of the summary.