Skip to content

Small tidbits cleanups

Cyril Danilevski requested to merge various_refactors into master

Description

As I'm trying to get back into pycalibration, I'm going through my uncommitted changes and keeping the ones that are sound and were never relevant enough to add to MRs I was doing at the time.
Here they are! All are quite small bits independent from one another, but maybe not all of them are tasteful (maybe len(iterable) == 0 is clearer than not iterable.)
So I'm presenting them to you. They're all drop-in replacement for the code they, well, replace :-)

The only curious change is in src/cal_tools/agipdutils_ff.py where I removed an unreachable if, which is handled a few lines earlier with a return.
I also replaced a has_parm function that was used in a single place with a if any(...).

Let me know what you think!

Thanks,
Cyril

How Has This Been Tested?

These were individually tested at the time of making the modifications.
I'm happy to attempt adding unit-tests or else if you think it relevant.

Relevant Documents (optional)

Types of changes

  • Style (formatting changes only, no code changes)
  • Refactor (refactoring code with no functionality changes)

Checklist:

Reviewers

@calibration

Merge request reports