Skip to content

Fix/user.status fattr missing

Robert Rosca requested to merge fix/user.status-fattr-missing into master

Description

If there is a problem with the migration it may fail to set the user.status file attribute. This means that we (1) can't check that the files have been migrated to know if calibration should start and (2) that the webservice wait_on_transfer loop continues for almost an hour, even though the file attribute will likely not be present until migration is manually triggered again.

This adds in a separate check for the attribute being present, and exits the wait_on_transfer loop after 5 minutes if it is not.

How Has This Been Tested?

Good question! It hasn't. I checked the logic of the check implemented in _check_fattr_present manually, but haven't tested this branch directly.

We could deploy it to the test server and request ITDM remove the flag on a run, then try triggering the calibration via MyMDC to see what happens?

Relevant Documents (optional)

https://euxfel-da.zulipchat.com/#narrow/stream/258300-calibration/topic/offline.20correction/near/249558060

Some DOC tickets

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I added tests where appropriate.

Reviewers

@calibration

Edited by Robert Rosca

Merge request reports