Skip to content

[AGIPD] Fix missing memory cell index in SlopesPC constant sanitization

Philipp Schmidt requested to merge fix/AGIPD-slopesPC-sanitization into master

Description

For every memory cell in the SlopesPC constant, nan values or values outside a certain boundary of amemory cell's median are meant to be replaced by the median. The masking operations for these replacements were missing the actual memory cell index, thus applying any change to all memory cells for a given pixel. This caused the result to both be wrong and the algorithm to scale quadratically with the number of memory cells. After the fix, the time for sanitization goes down from ~6min to ~3s.

How Has This Been Tested?

Low level deconstruction of the algorithm and what it's doing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Reviewers

@ahmedk @jsztuk

Merge request reports