Skip to content
Snippets Groups Projects

[AGIPD] [PC] FEAT: Optimisation of the PC characterisation notebook.

Merged Vratko Rovensky requested to merge feat/new_agipd_pc into master

Description

Optimisation of the AGIPD PC notebook.

The script incorporates a new merging of data by means of extra-data. New merging fixes the bug in the previous version causing impartial merging of data for the last trains.

Notebook contains enhanced plotting functionality with more unified output and fixes the calculation for the linearity deviation of the fits. PC sanitization is now part of the constants creation process.

How Has This Been Tested?

The code has been tested with AGIPD SPB data from proposal p900215.

Relevant Documents (optional)

Types of changes

  • Bug fix (non-breaking change which fixes an issue) --> Fixing incomplete merging for the last trains. Fixing calculation for the linearity deviation of the fits.
  • New feature (non-breaking change which adds functionality) --> Additional plots for better analysis control. Possibility to specify ranges of values for high gain region and medium gain region instead of using clustering algorithm. Possibility to use only a specified number of trains. PC sanitisation is now part of the constant creation process.
  • Docs (changes to the documentation) --> Added and changed few sentences here and there to explain the changes in the code that were made.
  • Refactor (refactoring code with no functionality changes) --> Got rid of the copy-paste lines for plotting and unified the produced output for the different module regions.

Checklist:

Reviewers

@ahmedk, @jsztuk

Edited by Vratko Rovensky

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Karim AhmedKarim Ahmed 2 years ago (Jul 28, 2022 5:47pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Karim Ahmed
  • Karim Ahmed
  • Karim Ahmed
  • Karim Ahmed
  • Karim Ahmed
  • Karim Ahmed
  • Karim Ahmed
  • Karim Ahmed
  • Karim Ahmed
  • Karim Ahmed
  • Karim Ahmed
  • Karim Ahmed
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading