Fix / report partition same as action slurm partition
A bug was reported by Ivana from the detector group.
Fix for running xfel-calibrate and building reports through exfel
partition outside of xcal
Description
How Has This Been Tested?
Running xfel-calibrate with upex-middle
and without. A report was generated fine and no errors.
Relevant Documents (optional)
sbatch: error: Batch job submission failed: User's group not permitted to use this partition
Types of changes
- Bug fix (non-breaking change which fixes an issue)
Checklist:
Reviewers
Merge request reports
Activity
assigned to @ahmedk
added Waiting for review label
- Resolved by Philipp Schmidt
Ugh, that is an unfortunate side effect of that prior change.
I'm not really happy about adding another argument for that. If we really need to, we should also stick to the term
finalize
rather thanreport
.Can we use the same partition as for the processing job before it? For corrections and manual
xfel-calibrate
runs those are the same anyway, and it's not a problem if we queue the reports for dark processing asupex-high
.
- Resolved by Karim Ahmed
- Resolved by Thomas Kluyver
LGTM
removed Waiting for review label
mentioned in commit f1b4a261