Skip to content
Snippets Groups Projects

SlopesFF with 352cells for correcting different cell conditions

Merged Karim Ahmed requested to merge feat/SlopesFF_with_352_cells_only into master
1 unresolved thread

This is related to https://git.xfel.eu/calibration/planning/-/issues/107

Description

As it turns out SlopesFF doesn't depend on operating memory cells. There is a plan to only inject FF constants for all 352 cells.

This MR:

  1. Adds a deviation during injection of these constants.
  2. Slicing the retrieved SlopesFF constant based on the number of operating memory cells.

How Has This Been Tested?

This was tested by injecting to max-exfl017 SlopesFF with a low deviation of 352 and then later retrieving them while asking for a constant with 64 memory cells.

https://in.xfel.eu/test_calibration/calibration_constants/20487#condition

Relevant Documents (optional)

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

Reviewers

@schmidtp @hammerd

Edited by Karim Ahmed

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Karim Ahmed added 743 commits

    added 743 commits

    • 3b8c7003...af6e09b5 - 741 commits from branch master
    • 49e44f07 - SlopesFF with 352cells for correcting different cell conditions
    • a5e06b52 - expose the error and remove the lower deviation

    Compare with previous version

  • Karim Ahmed marked this merge request as ready

    marked this merge request as ready

  • Karim Ahmed changed milestone to %3.9.0

    changed milestone to %3.9.0

  • assigned to @ahmedk

  • removed In Progress label

  • Karim Ahmed changed the description

    changed the description

  • Philipp Schmidt
  • Philipp Schmidt
  • Thanks, LGTM!

  • Thank you for the review!

  • merged

  • Karim Ahmed mentioned in commit 8dfb01d7

    mentioned in commit 8dfb01d7

  • Karim Ahmed mentioned in merge request !806 (merged)

    mentioned in merge request !806 (merged)

  • Please register or sign in to reply
    Loading