SlopesFF with 352cells for correcting different cell conditions
This is related to https://git.xfel.eu/calibration/planning/-/issues/107
Description
As it turns out SlopesFF doesn't depend on operating memory cells. There is a plan to only inject FF constants for all 352 cells.
This MR:
- Adds a deviation during injection of these constants.
- Slicing the retrieved SlopesFF constant based on the number of operating memory cells.
How Has This Been Tested?
This was tested by injecting to max-exfl017 SlopesFF with a low deviation of 352 and then later retrieving them while asking for a constant with 64 memory cells.
https://in.xfel.eu/test_calibration/calibration_constants/20487#condition
Relevant Documents (optional)
Types of changes
- New feature (non-breaking change which adds functionality)
Checklist:
Reviewers
Merge request reports
Activity
- Resolved by Karim Ahmed
I thought
calPy
already checked to slice down any constants to the actual number of memory cells, but I may be wrong or it's not for these constants.calng
did for DSSC, I'll assume the same for AGIPD @hammerd ?
- Resolved by Karim Ahmed
added In Progress label
added 743 commits
-
3b8c7003...af6e09b5 - 741 commits from branch
master
- 49e44f07 - SlopesFF with 352cells for correcting different cell conditions
- a5e06b52 - expose the error and remove the lower deviation
-
3b8c7003...af6e09b5 - 741 commits from branch
changed milestone to %3.9.0
assigned to @ahmedk
removed In Progress label
added Waiting for review label
- Resolved by Karim Ahmed
- Resolved by Karim Ahmed
mentioned in commit 8dfb01d7
mentioned in merge request !806 (merged)