Skip to content
Snippets Groups Projects

[JUNGFRAU] Add skip-plots option to correct

Merged [JUNGFRAU] Add skip-plots option to correct
feat/jf-correct-skip-plots into master
1 unresolved thread
Merged Philipp Schmidt requested to merge feat/jf-correct-skip-plots into master
1 unresolved thread

Description

Analogue option to https://git.xfel.eu/detectors/pycalibration/-/merge_requests/581 for JF correct

How Has This Been Tested?

Running xfel-calibrate jungfrau correct --skip-plots

Types of changes

  • New feature (non-breaking change which adds functionality)

Reviewers

@ahmedk @tmichela

Edited by Philipp Schmidt

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
notebooks/Jungfrau/Jungfrau_Gain_Correct_and_Verify_NBC.ipynb
50 50 "mem_cells = 0 # leave memory cells equal 0, as it is saved in control information starting 2019.\n",
51 51 "bias_voltage = 180 # will be overwritten by value in file\n",
52 52 "\n",
53 "# Parameters for plotting\n",
54 "skip_plots = False # exit after writing corrected files\n",
  • Karim Ahmed
    Karim Ahmed @ahmedk ·
    Owner

    That makes sense. LGTM

  • Philipp Schmidt added 1 commit

    added 1 commit

    • 07bd2262 - Add skip-plots option to JF correct

    Compare with previous version

  • Philipp Schmidt
    Philipp Schmidt @schmidtp ·
    Author Owner

    Thanks for review!

  • Philipp Schmidt mentioned in commit 060ed13a

    mentioned in commit 060ed13a

  • Philipp Schmidt merged

    merged

  • Karim Ahmed removed Waiting for review label

    removed Waiting for review label

    • Please register or sign in to reply

    Legal Notice | Contacts