Skip to content

remove source selection and only select instr sources for the n_trains check part

Karim Ahmed requested to merge fix/select_needed_sources_only into master

It was reported by MID that requesting a dark for /gpfs/exfel/exp/MID/202230/p900249/raw (runs: 198, 199, and 200) was not successful.

After investigating the issue with @schmidtp and @kluyvert, we agreed that I fix the notebook and create a hotfix for MID to be able to request darks.

Description

The issue was related to broadly selecting karabo_id_control* sources. As the litfrim device was selected and was not operated. It had no trains, misleading the notebook of an empty run.

I have removed that source selective part, as this was only used to check:

  1. If run folder had data.
  2. Number of files to process
  3. Data size to process.

Now the three points are deducted from a temp dc variable within the loop.

How Has This Been Tested?

I tested with the mentioned dark request runs /gpfs/exfel/exp/MID/202230/p900249/raw as well as the reference runs for SPB /gpfs/exfel/exp/SPB/202131/p900215/raw and HED /gpfs/exfel/exp/HED/202131/p900228/raw.

Relevant Documents (optional)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@schmidtp @kluyvert @roscar

Merge request reports