Skip to content

Draft: [LPD] [Dark] Allow mem_cells to affect LPD condition without changing constant shape

Thomas Kluyver requested to merge lpd-consts-mem-cells into master

Description

This is intended to allow a manual workaround for proposal 3073 while we work out a better way to handle LPD veto patterns for calibration constants.

At present, the mem_cells parameter affects both the constant created (looking at the first N cells in the detector) and the condition it's injected with. As far as I can see, it's always left set to 512. This separates those two purposes, so the constant creation always looks at all 512 possible cells (and generates a (256, 256, 512) array), but we can set mem_cells to some other value to distinguish constants with fewer cells in use.

This doesn't tell us which 200 cells were used or in what order - in the longer term, we want to record that and use it for selecting constants. This is just to let us do something relatively quick for p3073.

How Has This Been Tested?

TBD

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.

Reviewers

@schmidtp

Merge request reports