Skip to content

[JUNGFRAU][DARK] Fixing BadPixelsDark WRONG_GAIN_VALUE

Karim Ahmed requested to merge fix/badpixel_wrong_gain_value into master

@mramilli pointed to me a dark request which shows BadPixelsMap with a WRONG_GAIN_VALUE bit for all pixels.

This is lead to finding a bug on how the WRONG_GAIN_VALUE is identified and assigned to the BadPixelsMap.

Description

A bad bug which affects burst and single cell jungfrau BadPixelsDark.

The WRONG_GAIN_VALUE for a cell and gain has been assigned to the whole badpixelmap across all cells and gains.

How Has This Been Tested?

Relevant Documents (optional)

/gpfs/exfel/d/cal/caldb_store/xfel/reports/SPB/SPB_IRDA_JF4M/dark/dark_900290_r45_r46_r47_221012_164547.pdf Screenshot_from_2022-10-13_15-39-57

After the fix:

Screenshot_from_2022-10-13_16-23-45

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@mramilli @schmidtp @hammerd

Edited by Karim Ahmed

Merge request reports