Account for setup time before proposal for partition choice
Description
See https://git.xfel.eu/calibration/planning/-/issues/157
Apparently it's a thing now that some instruments no longer schedule the full week for the official proposal, but instead assign the first 1-2 days as "set-up" to temper the user's expectation that the scientific part may begin on day 0.
This classes with us using the myMDC beamtime records for high priority access again. We agreed to give access to
upex-middle
already 2d (could be configurable) before a user proposal.
How Has This Been Tested?
Added test case
Types of changes
- New feature (non-breaking change which adds functionality)
- Test (additional or refactored tests)
Checklist:
- My code follows the code style of this project.
- I have updated the documentation accordingly.
- I added tests where appropriate.
Reviewers
Merge request reports
Activity
changed milestone to %3.7.2
added Waiting for review label
requested review from @schmidtp
assigned to @roscar
Thanks, LGTM.
I have pondered the question whether this is too generic and could be abused for malicious purposes. But I couldn't think of a case other than multi-part proposals that correct runs from a prior run just before a following one - but even here one can think of legitimate cases such as re-correcting prior data to aid in set-up. Any other thoughts?
mentioned in commit 667f3fd3