[DataFile] Add support for older INDEX and METADATA versions

Review changes
Download
Patches
Plain diff

Merged [DataFile] Add support for older INDEX and METADATA versions

fix/datafile-old-index-format into master

Overview 8
Commits 3
Pipelines 0
Changes 3

Merged Philipp Schmidt requested to merge fix/datafile-old-index-format into master 2 years ago

Overview 8
Commits 3
Pipelines 0
Changes 3

Description

Alternative to https://git.xfel.eu/detectors/pycalibration/-/merge_requests/751.

This adds a new from_file= argument to DataFile.create_index to take timestamp, validity flag and origin potentially from an existing file. train_ids remains an explicit argument (could theoretically also be None and just take the entire file, but the rest of the API is not really suited for this use case) and is used to filter into the existing file.

@kluyvert Maybe we could introduce a comparable logic FileAccess already has for the validity flag for timestamps and origin?

How Has This Been Tested?

@ahmedk Could you please run this on the exact same file you originally did for https://git.xfel.eu/detectors/pycalibration/-/merge_requests/751?

Types of changes

Bug fix (non-breaking change which fixes an issue)

Reviewers

@ahmedk

Edited 2 years ago by Philipp Schmidt

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

None

Select assignees

0 Reviewers

Request review from

Labels

None

Select labels

Manage project labels

Milestone

None

Time tracking

No estimate or time spent

0 Participants

There are currently no pipelines.

To run a merge request pipeline, the jobs in the CI/CD configuration file must be configured to run in merge request pipelines and you must have sufficient permissions in the source project.