Skip to content
Snippets Groups Projects

[Gotthard2][CORRECT] calcat interface

Merged Karim Ahmed requested to merge gotthard2_calcat_interface into master

Start using calcat interface with Gotthard2 correction.

Related to https://git.xfel.eu/calibration/planning/-/issues/150

Description

notebooks/Gotthard2/Gotthard2_retrieve_constants_precorrection_NBC.ipynb:

  • Retrieve all constants in one go and validate the availability for the constants and raise Error/Warning accordingly.
  • Updating the YAML metadata keys based on the attributes in the CalibrationData metadata object.

notebooks/Gotthard2/Correction_Gotthard2_NBC.ipynb:

  • Using calcat interface to retrieve constants if YAML is not available.

How Has This Been Tested?

Tested against reference runs

Relevant Documents (optional)

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

Reviewers

@schmidtp @kluyvert

Edited by Karim Ahmed

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • LGTM other than those minor points.

  • Karim Ahmed added 1 commit

    added 1 commit

    • d8bbce0d - Error out if dark constants are missing for all modules

    Compare with previous version

  • Karim Ahmed added 1 commit

    added 1 commit

    • 3d8f17ff - Error out if dark constants are missing for all modules

    Compare with previous version

  • Karim Ahmed resolved all threads

    resolved all threads

  • Karim Ahmed changed milestone to %3.9.0

    changed milestone to %3.9.0

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading