Skip to content

Draft: Check run for being dark before replying to myMDC request

Philipp Schmidt requested to merge fix/skip-corrections-earlier into master

Description

The back then controversial change to automatically prevent dark runs from being corrected has been mentioned again. When corrections are started manually in myMDC, the somewhat misleading message "Queued successfully" is presented even though no actual jobs are ever queued.

The reason here is that the check for run type was done in the _continue coroutine running after replying to myMDC. Since it does not actually access any data on disk, this MR moves the check to before the reply and change it acordingly if the run is skipped.

Potential implications are that myMDC doesn't like to be called while waiting for a ZMQ reply.

How Has This Been Tested?

TBD on max-exfl017

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Reviewers

@ahmedk @maial @danilevc

Edited by Philipp Schmidt

Merge request reports