Skip to content
Snippets Groups Projects

[AGIPD] Fix checking ccv_variant condition for AGIPD

Merged Karim Ahmed requested to merge fix/agipd_variant into master
All threads resolved!

Description

I realized that the condition for checking the ccv_variant is wrong in agipdlib.py

It's a dictionary with a key for constant names. I was checking if the whole dict is 0.

The check is fixed. Before this fix if a correction for old data was requested. No sanitization was done.

How Has This Been Tested?

Relevant Documents (optional)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@hammerd @roscar

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • :flushed:

    Interesting this didn't come up in all this time. Minor nitpick, otherwise LGTM.

  • Karim Ahmed added 1 commit

    added 1 commit

    Compare with previous version

  • Philipp Schmidt approved this merge request

    approved this merge request

  • Karim Ahmed resolved all threads

    resolved all threads

  • Thank you for the review!

  • merged

  • Karim Ahmed mentioned in commit 4e9c56ff

    mentioned in commit 4e9c56ff

  • David Hammer mentioned in issue calng#44

    mentioned in issue calng#44

  • Please register or sign in to reply
    Loading