Skip to content

Remove karabo_data from dependencies

Thomas Kluyver requested to merge fix/rm-karabo-data into master

Description

karabo_data was renamed to EXtra-data years ago, but we're still installing both, and we don't need to.

How Has This Been Tested?

Grepping for code using karabo_data. This finds:

  • One 'playground' LPD notebook, not used in production: Investigate-Non-Linearity_APD.ipynb.
  • Parts of the 'legacy' tests, which we inherited in a semi-broken state and don't use.
  • The cal_tools.lpdlib module has an option for karabo_data_mode, but doesn't actually import karabo_data itself. This appears to be unused, but I think it would work just as well with data from EXtra-data if anything did use it.

I haven't tried to change any of these pieces, because it's not worth spending time changing stuff that's not used. If any of them are wanted again, it should be straightforward to replace karabo_data with extra_data.

Types of changes

  • Chore (non-code changes, e.g. comments, readme, grammar, etc...)

Reviewers

@ahmedk @schmidtp

Merge request reports