Skip to content
Snippets Groups Projects

[LPD] [Dark] Use EXtra-data to create darks from >1 sequence file

Merged Thomas Kluyver requested to merge feat/lpd-darks-extra-data into master
All threads resolved!

Description

At present, only the first sequence file in a dark run for each module is used to create darks for LPD-1M. This appears to be typically 256 trains. The notebook skips the first 10 trains by default, leaving 246. Hazem tells me this is not enough for good quality constants.

This adapts the notebook to use EXtra-data and select a given number of trains from the dark runs, regardless of how many files they are spread over.

I'd suggest reviewing the two commits separately:

  1. I removed some unnecessary complexity for looping over capacitor settings, even though the notebook only allowed for a single setting. This is not strictly necessary, but it makes the code easier to follow.
  2. The second commit introduces EXtra-data.

How Has This Been Tested?

Ran the notebook interactively with data from p3338, for a single module, to check that it works and the plots look similar to ones in an injected report for the same dark runs.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.

Reviewers

@yousefh @ahmedk @schmidtp

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Karim Ahmed
  • Karim Ahmed
  • Karim Ahmed
  • Thomas Kluyver added 1 commit

    added 1 commit

    • 1505a482 - Simplify showing capacitor setting

    Compare with previous version

  • Thomas Kluyver added 1 commit

    added 1 commit

    • 1aa13123 - Use pathlib in place of os.path

    Compare with previous version

  • Thomas Kluyver resolved all threads

    resolved all threads

  • Thank you, Thomas.

    LGTM.

  • Thanks for the review :slight_smile:

  • merged

  • Thomas Kluyver mentioned in commit 130a3247

    mentioned in commit 130a3247

  • Philipp Schmidt changed milestone to %3.11.0

    changed milestone to %3.11.0

  • Please register or sign in to reply
    Loading