Skip to content

[LPD][Correct] Harden against empty sequence sets with train-on-demand

Philipp Schmidt requested to merge feat/LPD-train-on-demand into master

Description

FXE operated on a train-on-demand mode last week, which coupled with the advanced VETO features in LPD allows the detector to actually not record any frames for trains without pulses. Unfortunately this is beyond the standard assumptions we're doing for valid data, and in particular caused empty sequence sets to be assigned to a particular correction job. While corrections handle this fine with just ignoring empty data, the data preview failed afterwards.

This MR tries to harden the LPD correct notebook by:

  1. Exiting before data preview when there are no output paths present from not writing any output files
  2. Exit immediately in the beginning if there are LPD frames and no SA1 pulses. While not relevant right now, the idea of this distinction is that no LPD frames but SA1 pulses should throw an error, not having any pulses will only generate a warning, or exit silently at the moment.

How Has This Been Tested?

p3273, p256

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Reviewers

@ahmedk @kluyvert

Merge request reports