Fix: Gain mode parameter wwas missing from Jungfrau parameter

Description

Gain mode is missing from Jungfrau_CalibrationData dark park parameters and as a result it was always removed from the condition table and this will cause wrong constant retrieval when correction fixed gain runs.

This is related to this ticket: https://redmine.xfel.eu/issues/154447

How Has This Been Tested?

This was tested locally and after fixing the bug in production and reprocessing runs 46, 22, 20 from the proposal mentioned in the ticket.

Relevant Documents (optional)

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@schmidtp @hammerd

assigned to @ahmedk

Concerning reference data, it looks both burst mode in general and fixed gain specifically (is it actually used outside of burst mode) are missing from https://git.xfel.eu/calibration/planning/-/issues/70?

There is burst mode for JF1M 106 [108, 109, 110] (JF1M, burst mode, NYI)

Ah, so what's the problem with using p900226, r106 for correct?

Sorry, I meant to say that there are burst mode reference runs for JF1M. But no fixed gain reference runs in general for Jungfrau.

I am using fixed gain runs 166, 168, 169 - p003051 for SPB_IRDA_JF4M for dark processing tests.

I don't remember why I have chosen those (most probably randomly chosen?), but as you can see they are not part of the collected reference runs from before.

You got me thoroughly confused, so let's just focus on the bottom line

If we solely use runs from the reference run set, what is missing?

Fixed gain runs for single and burst mode for Jungfrau.

But isn't burst mode always fixed gain?

I don't think so.

This is a dark processing from yesterday for SPB_CFEL_JF1M in burst mode and adaptive gain. dark_005418_r31_r32_r33_230531_231155.pdf

Fix LGTM

Thank you !

merged

mentioned in commit 42b14560

changed milestone to %3.11.0

changed milestone to %3.10.3