Skip to content

[LPD] [Correct] Write corrected data as new source and link to old source name

Thomas Kluyver requested to merge feat/output-source-lpd1m into master

Description

We've wanted for some time to use different source names for corrected data, so you can refer unambiguously to corrected & raw data within one run. There's an overview issue for this: https://git.xfel.eu/calibration/planning/-/issues/170

This implements step 1 of that plan for one detector (LPD 1M): duplicating the source in the files to both the old name and a new one. Following what we did with LPD Mini, the new names look like FXE_DET_LPD1M-1/CORR/0CH0:output (DET -> CORR and xtdf -> output). It uses HDF5 soft links, so we're not duplicating all the data.

We should ideally be reasonably confident we'll go through with this plan before we merge this, because backing out of it could be messy.

How Has This Been Tested?

Run the notebook interactively and loaded the output (/gpfs/exfel/data/scratch/kluyvert/lpd-corr-p3338-r137) with EXtra-data.

Relevant Documents (optional)

image

image

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.

Reviewers

@schmidtp

Merge request reports