Skip to content
Snippets Groups Projects

[LPD-Mini] Rework cell order condition to match LPD-1M again

Merged Thomas Kluyver requested to merge feat/lpdmini-auto-cell-order into master

Description

We changed the memory cell order condition for LPD-1M in !851 (merged) to automatically use cell order when the memory cells wrap around within a train. This makes the same change for LPD Mini. Without this change, enabling cell order for LPD Mini would break (it's disabled by default).

How Has This Been Tested?

Run both the correction & characterisation notebooks interactively to the point where they set up conditions, checked that the condition object is as expected (no cell order parameter), and they can retrieve constants.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.

Reviewers

@ahmedk @schmidtp

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Thomas KluyverThomas Kluyver 1 year ago (Jul 4, 2023 12:45pm UTC)

Merge details

  • Changes merged into master with 09dde74c.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading