Skip to content
Snippets Groups Projects

[LPD] [Dark] Don't use multiprocessing inside multiprocessing when opening run

Merged Thomas Kluyver requested to merge fix/lpd-dark-daemon-children into master

Description

There was an error opening the run if its JSON cache file didn't already exist, because it tried to use multiprocessing inside multiprocessing, which is not allowed. This avoids that scenario. Behaviour should be unchanged if the cache file exists.

How Has This Been Tested?

No specific tests, but the parallelize=False option was added for precisely this use case - where you're already using a multiprocessing pool outside opening the run - so I'm confident in it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.

Reviewers

@schmidtp @ahmedk

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading