Revised CalCat API
-
Review changes -
-
Download -
Patches
-
Plain diff
This is based on our discussion last week, but it's still a WIP. In particular, I haven't implemented actually loading the constants yet.
I've tweaked the design slightly: rather than having CalibrationData
subclasses for each detector type, you use CalibrationData.from_conditions()
with a detector specific object like AGIPDConditions
. Jump to the tests to see what this looks like.
Questions:
-
How to deal with missing modules? - A module may be missing for one type of constant but not for another
- How do we even tell if modules are missing - should we query the PDUs so we know how many modules to expect?
-
How to deal with missing calibration types (e.g. SlopesPC) - Especially if one group (e.g. illuminated) not found - this currently raises an error, even if we have other constants we could return
-
Naming: -
'Calibrations' vs 'calibration' types vs 'constant types' (e.g. Offset, SlopesPC -
'Modules' vs 'aggregators'
-
-
How many of SingleConstantVersion fields do we actually want? -
Should .select_modules()
and.select_calibrations()
take*args
or a list?
Edited by Thomas Kluyver
Merge request reports
Compare and
Show latest version
- version 460e9b1ed5
- version 45320b21f1
- version 4484b5d223
- version 43a537f3a3
- version 4251e1a6e7
- version 41e8c55a17
- version 40fab99f56
- version 39bbfa02a6
- version 38525482b5
- version 370399fbb3
- version 36b3066fb1
- version 35cab1d55a
- version 3468c18ce3
- version 33e2127548
- version 328ebbc2de
- version 31c6659def
- version 30a75e9ee1
- version 2954f8fc83
- version 289847e518
- version 274229e8a0
- version 263b573aa4
- version 25b9ba6200
- version 24900c9d05
- version 231ed72b68
- version 227e94a027
- version 21e59c9fc3
- version 200281ecfe
- version 1952e5cd3b
- version 18e90f5492
- version 1759ab8ecd
- version 16a95d67d0
- version 1571eac33d
- version 146a1db818
- version 138a7d05a7
- version 12cae322cb
- version 115b6ce2d4
- version 10a5299e1d
- version 94f136f4a
- version 8ac8dab49
- version 7afab4fc3
- version 6674ffe18
- version 5963331af
- version 4c2fa065a
- version 33fce0af0
- version 20be3ef4c
- version 12f501f14
- master (base)
- latest version63a727ee66 commits,
- version 460e9b1ed565 commits,
- version 45320b21f164 commits,
- version 4484b5d22363 commits,
- version 43a537f3a361 commits,
- version 4251e1a6e760 commits,
- version 41e8c55a1759 commits,
- version 40fab99f5658 commits,
- version 39bbfa02a657 commits,
- version 38525482b555 commits,
- version 370399fbb354 commits,
- version 36b3066fb152 commits,
- version 35cab1d55a50 commits,
- version 3468c18ce348 commits,
- version 33e212754846 commits,
- version 328ebbc2de45 commits,
- version 31c6659def44 commits,
- version 30a75e9ee142 commits,
- version 2954f8fc8341 commits,
- version 289847e51840 commits,
- version 274229e8a039 commits,
- version 263b573aa438 commits,
- version 25b9ba620037 commits,
- version 24900c9d0536 commits,
- version 231ed72b6835 commits,
- version 227e94a02734 commits,
- version 21e59c9fc333 commits,
- version 200281ecfe31 commits,
- version 1952e5cd3b30 commits,
- version 18e90f549229 commits,
- version 1759ab8ecd28 commits,
- version 16a95d67d026 commits,
- version 1571eac33d25 commits,
- version 146a1db81821 commits,
- version 138a7d05a720 commits,
- version 12cae322cb19 commits,
- version 115b6ce2d418 commits,
- version 10a5299e1d17 commits,
- version 94f136f4a16 commits,
- version 8ac8dab4915 commits,
- version 7afab4fc314 commits,
- version 6674ffe1813 commits,
- version 5963331af12 commits,
- version 4c2fa065a11 commits,
- version 33fce0af010 commits,
- version 20be3ef4c9 commits,
- version 12f501f148 commits,
Compare changes
- Side-by-side
- Inline
Files
3Loading